t1meshift
/
expressCart
mirror of https://github.com/t1meshift/expressCart.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix bugs in Stripe and crashes in Paypal modules 

- Paypal: deprecated req.param in express
- Paypal: newId was saving in DB as empty string
- Stripe: newId was undefined, resulting in wrongly reported unsuccesful
transaction
- Stripe: client email was not sending because was undefined
react_convert
arings 2018-01-31 17:57:56 +01:00
parent 32caf0318c
commit c2184649fa
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
routes/payments/paypal.js
View File

@ -12,7 +12,7 @@ router.get('/checkout_return', (req, res, next) => {
let db = req.app.db; let db = req.app.db;
let config = common.getConfig(); let config = common.getConfig();
let paymentId = req.session.paymentId; let paymentId = req.session.paymentId;
let payerId = req.param('PayerID'); let payerId = req.query['PayerID'];
let details = {'payer_id': payerId}; let details = {'payer_id': payerId};
paypal.payment.execute(paymentId, details, (error, payment) => { paypal.payment.execute(paymentId, details, (error, payment) => {
@ -190,10 +190,7 @@ router.post('/checkout_action', (req, res, next) => {
} }
// get the new ID // get the new ID
let newId = ''; let newId = newDoc.insertedIds['0'];
if(newDoc.insertedIds.length > 0){
newId = newDoc.insertedIds[0].toString();
}
// set the order ID in the session // set the order ID in the session
req.session.orderId = newId; req.session.orderId = newId;

4
routes/payments/stripe.js
View File

@ -60,7 +60,7 @@ router.post('/checkout_action', (req, res, next) => {
} }
// get the new ID // get the new ID
let newId = newDoc.insertedIds; let newId = newDoc.insertedIds['0'];
// add to lunr index // add to lunr index
common.indexOrders(req.app) common.indexOrders(req.app)
@ -70,7 +70,7 @@ router.post('/checkout_action', (req, res, next) => {
// set the results // set the results
req.session.messageType = 'success'; req.session.messageType = 'success';
req.session.message = 'Your payment was successfully completed'; req.session.message = 'Your payment was successfully completed';
req.session.paymentEmailAddr = newDoc.orderEmail; req.session.paymentEmailAddr = newDoc.ops[0].orderEmail;
req.session.paymentApproved = true; req.session.paymentApproved = true;
req.session.paymentDetails = '<p><strong>Order ID: </strong>' + newId + '</p><p><strong>Transaction ID: </strong>' + charge.id + '</p>'; req.session.paymentDetails = '<p><strong>Order ID: </strong>' + newId + '</p><p><strong>Transaction ID: </strong>' + charge.id + '</p>';